Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can review projects using the /review command. #27

Closed
tannerwelsh opened this issue Jun 16, 2016 · 7 comments
Closed

Players can review projects using the /review command. #27

tannerwelsh opened this issue Jun 16, 2016 · 7 comments
Assignees
Milestone

Comments

@tannerwelsh
Copy link
Contributor

tannerwelsh commented Jun 16, 2016

Completeness and quality are both percent scores between 0-100. Value passed can be a decimal, but will be rounded to the hundreds place after entering.

  • /review #project-id --completeness 89 --quality 63.1: review both completeness and quality in one command
  • /review #project-id -c28.2 -q63.1: review both completeness and quality, using short-form options
  • /review #project-id --completeness 89: review just completeness
  • /review #project-id -q 63.1: review just quality
  • /review #project-id: display the user's current review for this project, with N/A as placeholders for missing completeness / quality values

Example Usage & Errors

@learner  > /review #silly-slug
@echo     > Project #silly-slug has 4 reviews. You have not reviewed project #silly-slug.

            To review this project, analyze their artifact:
            > http://link.to.artifact/

            Use the rubric provided to calculate and submit a `--completeness` and `--quality` score.
@learner  > /review #silly-slug --completeness 89
@echo     > Completeness score captured for #silly-slug! Review is not yet complete.
@learner  > /project list --in-review
@echo     > You have reviewed 2/5 projects this cycle. Nice work!

               Project                  C    Q    Artifact
            X  #terrible-tiger          63   42   https://github.com/owner/repo
            X  #anxious-aardvark        19   77   https://github.com/owner/repo
            -  #silly-slug              89        https://github.com/owner/repo
            -  #fantastic-falcon                  https://github.com/owner/repo
            -  #creepy-caterpillar                https://github.com/owner/repo
@learner  > /review --quality 103
@echo     > Error: missing project id.

            When reviewing a project, be sure to include its id (for example, #bitter-bunny-2).

            Use `/review --help` to read the docs.

@learner  > /review #silly-slug --quality 103
@echo     > Error: invalid quality score.

            Quality scores must be between 1 and 100 inclusive. Decimals up to the hundreds place are allowed.

            Use `/review --help` to read the docs.

@learner  > /review #silly-slug --quality 72
@echo     > Quality score captured for #silly-slug. Review is complete. Thank you for your input.
@learner  > /review #fantastic-falcon -c75.3 -q80.8
@echo     > Completeness and quality scores captured for #fantastic-falcon! Review is complete. Thank you for your input.

originated from LearnersGuild/learning-os-software#76

@jeffreywescott jeffreywescott added this to the v0 milestone Jun 17, 2016
@jeffreywescott jeffreywescott changed the title Project reviews include completeness evaluation Players can provide "completeness" review using the /review command. Jun 20, 2016
@jeffreywescott jeffreywescott changed the title Players can provide "completeness" review using the /review command. Players can review projects using the /review command. Jun 20, 2016
@jeffreywescott
Copy link
Contributor

@tannerwelsh -- please see my updated issue description and make mods as needed.

@tannerwelsh
Copy link
Contributor Author

Looks great @jeffreywescott, thanks! I can spell out more help/error text when needed too.

@jeffreywescott
Copy link
Contributor

@tannerwelsh It would be great to get any error text captured here ASAP so we can avoid another round-trip of spec / implementation.

@tannerwelsh
Copy link
Contributor Author

@jeffreywescott will do. I've got some bandwidth this morning.

@jeffreywescott
Copy link
Contributor

👍

@tannerwelsh
Copy link
Contributor Author

Updated description based on guide content produced in LearnersGuild/learning-os-software#120

@bundacia
Copy link
Contributor

Closing this ticket and creating a ticket for the UI polish that got left out in the first pass: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants