Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(JWTAuthentication): unexpected 500 responses #1370

Merged
merged 1 commit into from May 9, 2019
Merged

fix(JWTAuthentication): unexpected 500 responses #1370

merged 1 commit into from May 9, 2019

Conversation

h-kanazawa
Copy link
Contributor

Describe your changes providing screenshots of UI changes if necessary.

How to simulate requests with expired JWT

  • Set a short time, e.g. '10s', to expiresIn in api/src/auth
  • Login and wait some seconds, and move pages. It will dispatch API Request to /api/connection
  • The responses code of /api/connection should be 401, instead of 500, which is before fixing.

@h-kanazawa h-kanazawa requested a review from ryasmi May 9, 2019 10:45
@ht2
Copy link
Contributor

ht2 commented May 9, 2019 •
edited

Useful as part of https://github.com/LearningLocker/enterprise/issues/940

@ht2 ht2 merged commit 8f4a070 into master May 9, 2019
@ht2 ht2 deleted the fix-unauthorized-error-in-API branch May 9, 2019 14:25
@HT2Bot
Copy link
Member

HT2Bot commented May 9, 2019

🎉 This PR is included in version 3.11.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HT2Bot HT2Bot added the released label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ht2 ht2 ht2 approved these changes

@ryasmi ryasmi Awaiting requested review from ryasmi

Assignees

@ryasmi ryasmi

Labels
released Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@h-kanazawa @ht2 @HT2Bot @ryasmi