Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependabot prefix character limit #35

Closed
fuadop opened this issue May 25, 2022 · 12 comments · Fixed by #36
Closed

Dependabot prefix character limit #35

fuadop opened this issue May 25, 2022 · 12 comments · Fixed by #36
Labels
accepting prs Yes please, send a pull request! ♥ status: in discussion Let's talk about it!

Comments

@fuadop
Copy link
Contributor

fuadop commented May 25, 2022

Read -> https://github.com/LearningTypeScript/projects/runs/6594975169

@JoshuaKGoldberg Looks like the commit message prefix of dependabot has to be changed to something shorter 🥲 . The prefix has a limit of 15 characters.

Probably we change the gitmoji on the prefix to something shorter like :art:.
@JoshuaKGoldberg
Copy link
Contributor

Lol. Maybe gitmoji isn't worth it... this is really getting to be a lot.

@JoshuaKGoldberg JoshuaKGoldberg added the status: in discussion Let's talk about it! label May 25, 2022
@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

Yea right !

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

Well gitmoji looks good 😌 .

@JoshuaKGoldberg
Copy link
Contributor

It does 😢 and I've always wanted it...

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

You could still browse for shorter gitmojis - https://gitmoji.dev , anyone that can go with "build" and a whitespace and won't go over 15 characters 😉

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022 •
edited

And also we can tweak the pull request title linter CI to ignore pull requests from dependabot too.

@JoshuaKGoldberg
Copy link
Contributor

Oh that's true! I like that - ignoring dependabot. +1

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

Yep, I think we should go with that then 👍🏾 .

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

@JoshuaKGoldberg
Help merge #26 , so I won't need to fix merge conflict again.. since I want to work on the same files.. (dependabot.yml and pull_request_title.yml).

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

Also can you attach the accepting:pr label to this issue 🤔 .

@JoshuaKGoldberg JoshuaKGoldberg added the accepting prs Yes please, send a pull request! ♥ label May 25, 2022
@JoshuaKGoldberg
Copy link
Contributor

Oop yes sorry, doing!

@fuadop
Copy link
Contributor Author

fuadop commented May 25, 2022

Thanks @JoshuaKGoldberg ✨

@fuadop fuadop mentioned this issue May 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs Yes please, send a pull request! ♥ status: in discussion Let's talk about it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ chore: ignore pr title linting on pull requests from dependabot fuadop/projects
2 participants
@JoshuaKGoldberg @fuadop