New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️ ci: run solutions test for file change in related project #63
⚗️ ci: run solutions test for file change in related project #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good start 🎉 ! I hadn't seen the tj-actions/changed-files
action before, thanks for teaching me about it. It looks like a perfect fit for what this PR needs 😄.
Requesting changes on a bit of code cleanup and also -unless you think this is a bad idea?- augmenting solutions.yml
instead of having two workflows.
I also just found out about the changed-files action 😅 . There are a few out there for this changed files. I saw about 3 but this one had the most starsss. |
Yea, I love the idea of augumenting it to one workflow ! It's brilliant ! @JoshuaKGoldberg ✨ |
Hey @JoshuaKGoldberg , I have made changes 😇 . How do you see this ? 😁 I think it looks better now . You're brilliant ! ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we missed a chmod +x
, heh - my bad. This looks pretty great so far otherwise!
It's hard to test this kind of thing locally though. Could you add a couple of commits that make some changes to project tests? At least one change that causes a failure, and at least one change that doesn't. That'll show that this PR works like it seems it does.
By the way, I'm going to be in and out of availability the next few days. You don't have to @ ping me - I've set notifications up so I'll see anything you push here. Feel free to re-request review with in the GitHub UI when this is ready.
Thanks! 🙌
…s executable permissions
hmm 🤔 , Looks like it's bent on the first few commits. |
Yesssss, I've done ittt. |
|
Agh sorry this dropped off my radar - reviewing now! If I ever take more than a week feel free to re-request review in the GitHub UI. Or if that button's not available ping me. It's definitely that I'm missing things, not that I'm ignoring you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks so much @fuadop, this is really fantastic 🔥. CI was getting really slow until now. And now it won't be!
Sure! |
PR Checklist
Overview
Runs test:solutions script for folder of changed files.