New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: add spellcheck ci #96
✨ feat: add spellcheck ci #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this in! There are a lot of failures in CI right now so we'll have to avoid/fix them in some way.
👋 @fuadop just checking in, is this still something you have time to look into? No worries if not, just making sure the issue isn't blocked! 😄 |
Hey @JoshuaKGoldberg 👋 , super sorry about the delay. About this, the words truly aren't existent, Do we create a dictionary file? but that's what we are trying to avoid here right? |
Hmm yeah, it is unfortunate how many words are being flagged right now. How about including only |
Hey @JoshuaKGoldberg, |
Hmm, is that with the TypeScript dictionary enabled? If so: I probably did it wrong on my end then 😄. |
Heh. Well, there are a lot of custom words in this repo: Typarium, Typespeare, etc. I think it makes sense that we'd have to add a dictionary. If that's a lot more work than you have time for, I can always take over - no worries! |
Yea, I can add that. how would you love the dictionary file to be stored in the repo? is the dictionary file okay in the root directory? |
Yeah that makes sense! If you have opinions on a better way I'd be interested though 😄. |
@@ -21,7 +21,7 @@ export const characters = [ | |||
}`, | |||
`{ | |||
"name": "Teela Na", | |||
"powers": ["telekenesis", "telepathy", "teleportation"], | |||
"powers": ["telekinesis", "telepathy", "teleportation"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😄 spellcheck really is useful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks for this @fuadop! ✨
PR Checklist
Overview
uses cspell for spellcheck on projects directory.