Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: add spellcheck ci #96

Merged
merged 6 commits into from Aug 16, 2022

Conversation

fuadop
Copy link
Contributor

@fuadop fuadop commented Jun 18, 2022

PR Checklist

Overview

uses cspell for spellcheck on projects directory.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this in! There are a lot of failures in CI right now so we'll have to avoid/fix them in some way.

@JoshuaKGoldberg
Copy link
Contributor

👋 @fuadop just checking in, is this still something you have time to look into?

No worries if not, just making sure the issue isn't blocked! 😄

@fuadop
Copy link
Contributor Author

fuadop commented Jul 27, 2022

Hey @JoshuaKGoldberg 👋 , super sorry about the delay.

About this, the words truly aren't existent, Do we create a dictionary file? but that's what we are trying to avoid here right?

@JoshuaKGoldberg
Copy link
Contributor

Hmm yeah, it is unfortunate how many words are being flagged right now. How about including only .md files in the spellcheck check? There are only two .md failures right now, both of which should go away once the typescript dictionary is configured to be used.

@fuadop
Copy link
Contributor Author

fuadop commented Aug 7, 2022

Hey @JoshuaKGoldberg,
I am actually seeing more than two words being flagged for .md files on my end 🤔.

image

@JoshuaKGoldberg
Copy link
Contributor

Hmm, is that with the TypeScript dictionary enabled? If so: I probably did it wrong on my end then 😄.

@fuadop
Copy link
Contributor Author

fuadop commented Aug 7, 2022

With the typescript dictionary, it reduced to 37 from 42.
image

@JoshuaKGoldberg
Copy link
Contributor

Heh. Well, there are a lot of custom words in this repo: Typarium, Typespeare, etc. I think it makes sense that we'd have to add a dictionary.

If that's a lot more work than you have time for, I can always take over - no worries!

@fuadop
Copy link
Contributor Author

fuadop commented Aug 7, 2022

Yea, I can add that. how would you love the dictionary file to be stored in the repo? is the dictionary file okay in the root directory?

@JoshuaKGoldberg
Copy link
Contributor

Yeah that makes sense! If you have opinions on a better way I'd be interested though 😄.

@@ -21,7 +21,7 @@ export const characters = [
}`,
`{
"name": "Teela Na",
"powers": ["telekenesis", "telepathy", "teleportation"],
"powers": ["telekinesis", "telepathy", "teleportation"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄 spellcheck really is useful!

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks for this @fuadop! ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit f26d424 into LearningTypeScript:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Investigate adding spell checking to CI
2 participants