Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPF API: Make custom domain / acm-cert options optional #92

Open
Learnspree opened this issue Apr 12, 2020 · 0 comments
Open

SPF API: Make custom domain / acm-cert options optional #92

Learnspree opened this issue Apr 12, 2020 · 0 comments
Labels
aws AWS Testing enhancement New feature or request

Comments

@Learnspree
Copy link
Owner

SPF API: Make custom domain / acm-cert options optional
Currently the spa-api serverless.yml deploy expects a provided custom domain and associated certificate to have been registered (see readme) and passed in.

This should be optional - by default it should just use a cloudfront.net domain which uses an AWS generated certificate.
@Learnspree Learnspree added enhancement New feature or request aws AWS Testing labels Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aws AWS Testing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Learnspree