This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
Refactor of the collectors and getters #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 11, 2014 01:02
|
Can someone review and perhaps merge the pull request? @mevdschee? |
|
I have not tested your code, but I really like what you did here. Thank you very much! |
|
Thanks! The reason I did this was because I wanted to have the branch name on the debug bar, but then I saw some room for improvement in other places! |
|
No updates? |
|
I've just pulled upstream, if this doesn't get merged soonish, I'll be deleting it. |
mevdschee
added a commit
that referenced
this pull request
Jan 13, 2016
Refactor of the collectors and getters
|
Sorry it took so long, thank you again for your effort! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allow for easier extension of this. Also added some options for users. See updated read me.