New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`magic-folder migrate` accepts invalid endpoint descriptions #226

Closed

exarkun opened this issue Aug 3, 2020 · 0 comments · Fixed by #257

Member

exarkun commented Aug 3, 2020

From #223 (comment):

I just learned that magic-folder migrate --listen-endpoint 6001 --node-directory ../path/to/node accepts that non-endpoint ar argument without complaining. Thus magic folder configuration will have just 6001 for api_endpoint, and passing that on will result in an error here.

exarkun mentioned this issue

Helper to convert api_endpoint into DecodedURL #223

Merged

meejah mentioned this issue

Only accept valid endpoints for 'magic-folder migrate' or 'magic-folder init' #257

Merged

meejah closed this as completed in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment