Pass dockerhub auth through circleci YAML correctly. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables using stored credentials to avoid dockerhub rate limits[1]. Previously, the contents of the `auth` key was being passed as keys to docker. [1] https://support.circleci.com/hc/en-us/articles/360050623311-Docker-Hub-rate-limiting-FAQ
|
Unfortunately, we can't really verify this is working until we land it, since the auth is not passed to PRs. |
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 88.69% 88.69%
=======================================
Files 31 31
Lines 2326 2326
Branches 276 276
=======================================
Hits 2063 2063
Misses 181 181
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
meejah
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using stored credentials to avoid dockerhub rate limits[1].
Previously, the contents of the
authkey was being passed as keys to docker.[1] https://support.circleci.com/hc/en-us/articles/360050623311-Docker-Hub-rate-limiting-FAQ