Use klein for web API.

[tomprince]

No description provided.

[codecov]

Codecov Report

Merging #362 (ee5fb25) into main (c7bfdbd) will increase coverage by 0.24%.
The diff coverage is 97.70%.

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   89.71%   89.95%   +0.24%     
==========================================
  Files          34       34              
  Lines        2566     2737     +171     
  Branches      303      330      +27     
==========================================
+ Hits         2302     2462     +160     
- Misses        181      184       +3     
- Partials       83       91       +8     

Flag	Coverage Δ
integration	48.52% <41.37%> (+0.58%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/magic_folder/web.py	97.23% <97.67%> (-0.58%)	⬇️
src/magic_folder/client.py	95.00% <100.00%> (ø)
src/magic_folder/uploader.py	99.44% <0.00%> (+0.21%)	⬆️
src/magic_folder/magic_folder.py	83.72% <0.00%> (+1.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bfdbd...ee5fb25. Read the comment docs.

[meejah]

Overall looks good. Couple questions inline -- and looks like we need several variations on the "folder not found" test now since this new layout needs to check that in multiple spots instead of one (i.e. a few untested error-cases).

[meejah]

I just noticed this seems to delete all the Nix config? Is that a mistake or...?

[tomprince]

I just noticed this seems to delete all the Nix config? Is that a mistake or...?

It doesn't look like klein is packaged for nix. I spent some time to see if I could add it to the packaging, but didn't have any luck. I figure it isn't valuable enough to block this change.

[tomprince]

I just noticed this seems to delete all the Nix config? Is that a mistake or...?

I've switched it to just remove the nix CI configuration. I'm inclined to land this, and someone with more nix experience can get the nix configs working again.

[meejah]

We'd have to lean on @exarkun for Nix help, basically ... would a pairing session (or two) pass enough Nix on to @tomprince or I so we could package a future Python dependency? (I'm thinking when we have an additional dependency or need to upgrade one).

I'm happy to land this, but I think we should at least file a bug about re-enabling Nix (and include a pointer to the deleted CI config so it's easy to find).

The last time I tried to use Nix I failed to find any way to make it work (on a Debian system .. including VMs) but of course things improve :)

[hacklschorsch]

I'm a bit hesitant to stand up to this since I still feel less-than-great at Nix, but I think I could give it a try. After having completed my over-due tasks for the "Orange" PrivateStorage milestone, which will take me probably two more weeks...

About the two sessions: I wish you luck! I have been wrestling with Nix since January and still don't feel very competent, but maybe you become friends with it quicker than me :)

[exarkun]

I guess you should go ahead with adding the klein dep and removing the Nix packaging. I will deal with the Nix packaging issues afterwards.

[meejah]

looks good, pending ticket for re-enabling Nix etc.