Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expedite review of broken Nano X apps #617

Closed
wickles opened this issue Jul 9, 2022 · 8 comments
Closed

Expedite review of broken Nano X apps #617

wickles opened this issue Jul 9, 2022 · 8 comments
Labels
applications Impacts the Ledger Live Applications bug Something isn't working

Comments

@wickles
Copy link

wickles commented Jul 9, 2022

Cosmos and Centrifuge apps have recently been updated to resolve issues preventing some users from accessing funds, yet the updated apps are still not available on Ledger Live. Since Nano X users have no way to sideload in order to access their funds, the review process for these updates should be prioritized.

Zondax/ledger-centrifuge#35
cosmos/ledger-cosmos#65
cosmos/ledger-cosmos#66

@wickles wickles added applications Impacts the Ledger Live Applications bug Something isn't working labels Jul 9, 2022
@gre
Copy link
Contributor

gre commented Jul 11, 2022

I will forward the information internally but this is not something to fix in "Ledger Live" itself, but more in the ledger nano app store api. thanks

@gre gre closed this as completed Jul 11, 2022
@FabriceDautriat
Copy link
Contributor

FabriceDautriat commented Jul 15, 2022

Sorry @wickles , but indeed opening the issue here will not help. It will be better addressed here

Please also read https://developers.ledger.com/docs/nano-app/submission-form/
We review Nano app updates after the developer/owner of the application actually pushes a PR an fills this form.

Zondax/ledger-centrifuge#35 ==> Indeed Ledger didn't release any updates yet. The last version is 2.34.4. We'll look into a possible PR made by Zondax or ICF to our repo to cover this. So far I haven't found one... (cc @tjulien-ledger )

cosmos/ledger-cosmos#65 ==> Apparently it's solved here. We need to receive a PR to our repo to be able to merge the fix. (cc @tjulien-ledger )

In any case, we are going to address this issue asap and contact the Zondax / ICF to discuss this further and avoid this situation happens again.

@wickles
Copy link
Author

wickles commented Jul 15, 2022

Hi @FabriceDautriat, thanks very much for your insight. This is growing into a systemic issue with moving parts across multiple repos and orgs so it only seems to make sense to discuss here. I cannot find any way to verify that the updated apps are in review so as far as I can tell this is the only way to ensure these things do not keep falling through the cracks and forgotten.

A bit confused here on why you refer only to Cosmos especially in your response to the Centrifuge issue? To reiterate, this issue applies not only to Cosmos but also Centrifuge, a Polkadot parachain. I believe that app was available behind the Developer/Experimental mode in Ledger Live. It seems like both apps' updates should be made available to users with that mode enabled.

@tjulien-ledger
Copy link

Hi @wickles, for cosmos we have received an update including the fix to the issue mentioned here and it will deployed very shortly. As for Centrifuge, we have not received any PRs though. I have contacted the developers though to see if they can open a PR so that we can update it. Once the PR is opened we will review it and publish it ASAP.

@FabriceDautriat
Copy link
Contributor

The new version 2.34.6 was released yesterday. Please give it a try @wickles !

@wickles
Copy link
Author

wickles commented Jul 20, 2022

Solved my problem for Cosmos, thanks! Any news for Centrifuge?

@jleni
Copy link
Contributor

jleni commented Jul 20, 2022

It is important to clarify that while Zondax has developed these apps, projects themselves may decide not to maintain them, how to prioritize funding, engage in a maintenance contracts, etc.

In the case of Cosmos, the issue was affecting other chains in the ecosystem (such as Kava). We had to discuss with ICF the path forward and coordinate a response.

With respect to Centrifuge, the chain went through backwards incompatible changes. Unfortunately, Zondax does not have any maintenance agreement with them. As an alternative, we have offered building a light app under an agreement we have with the web3 foundation. This light app could/should be submitted by the Centrifuge team.

@wickles
Copy link
Author

wickles commented Jul 21, 2022

With respect to Centrifuge, the chain went through backwards incompatible changes. Unfortunately, Zondax does not have any maintenance agreement with them. As an alternative, we have offered building a light app under an agreement we have with the web3 foundation. This light app could/should be submitted by the Centrifuge team.

That is interesting. In the Centrifuge issue that I linked they suggested that the latest (unverified) version should support the parachain.

Hi! There's a new release (v1.1005.0) that support Centrifuge parachain balances pallet. As LNX doesn't support unofficial app sideloading (aka you can only install apps in Ledger Live) this app version is, for the moment, only available for NanoS and NanoSP using our installers, found in the latest release.

I got hold of a Nano SP just to test this out and it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
applications Impacts the Ledger Live Applications bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants