You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the requests are synchronous and the underlying implementation does not properly handle exceptions (no retry, a network error harshly throws an un-recoverable error, no JSON parsing exceptions handling, etc.).
This basic implementation could be greatly improved by:
Performing async requests using a proper module (e.g. axios)
Adding a retry mechanism
Making the headers more flexible (to handle different external providers)
Taking into account the limitations from external APIs (e.g. by ensuring some delay between each request)
From the user perspective, the new implementation should:
Not be noticeable when operating optimally (that is: when no network error and no exception): the derived addresses should be sorted by a) address type (legacy, Segwit), then, b) by account number and c) index. They also should be displayed one by one rather than at once, at the end of the whole analysis.
When recoverable exceptions occur, a transient error message should be displayed (e.g. "Network issue, retrying...") and be removed once the exception had been properly handled.
When an un-recoverable exception occurs, the reason should be clearly explained to the user (e.g. "Network error: authentication issue", "JSON parsing error: {raw response body}")
The text was updated successfully, but these errors were encountered:
Currently, the requests are synchronous and the underlying implementation does not properly handle exceptions (no retry, a network error harshly throws an un-recoverable error, no JSON parsing exceptions handling, etc.).
xpub-scan/src/helpers.ts
Lines 13 to 35 in 3b64b7f
This basic implementation could be greatly improved by:
From the user perspective, the new implementation should:
The text was updated successfully, but these errors were encountered: