Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting for Weekdays, Months and Clothes sizes. #23

Closed
1 of 3 tasks
LeeWannacott opened this issue Apr 19, 2021 · 3 comments
Closed
1 of 3 tasks

Add sorting for Weekdays, Months and Clothes sizes. #23

LeeWannacott opened this issue Apr 19, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@LeeWannacott
Copy link
Owner

LeeWannacott commented Apr 19, 2021 •
edited

table-sort-js doesn't currently sort for Weekdays, Months, Clothe Sizes.
You could implement these on a class tag for <th> e.g class="months" class="weekdays" class="clothing-sizes".

Months: January, February, March, April, May, June, July, August, September, October, November, December.
Weekdays: Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday.
Clothe sizes: XS, S, M, L, XL ....

  • days-of-week
  • months
  • clothes-sizes
@LeeWannacott LeeWannacott added the good first issue Good for newcomers label Apr 19, 2021
@LeeWannacott LeeWannacott changed the title Add sorting for Weekdays, Months and Clothe sizes. Add sorting for Weekdays, Months and Clothes sizes. Apr 19, 2021
@LeeWannacott LeeWannacott removed the good first issue Good for newcomers label Apr 20, 2021
@LeeWannacott LeeWannacott added the good first issue Good for newcomers label May 1, 2021
@LeeWannacott
Copy link
Owner Author

days-of-week implemented in commit: cedaf10

@LeeWannacott
Copy link
Owner Author

Should I close this issue in favour of using data-sort and data-attributes 🤔 💭 ?

@LeeWannacott
Copy link
Owner Author

Closed in favor of users using data-sort. 88fae66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeeWannacott