-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hoist baseline eslint and prettier config for app #53
Comments
|
also, I noticed you've been pushing directly to main. FYI the linting workflow only runs on PR builds https://github.com/Left-on-Read/leftonread/blob/main/.github/workflows/app-format.yml (looks like you haven't done any work on the app so more just FYI). I don't think we should turn it on for main tho cause then we'll get ugly "Github bot" commits on main. Alternative is we turn that workflow off and use a githook like husky. But I find that people may get impatient and may force skip the pre commit hook if they need to commit quickly. |
I'm going to look into hoisting prettier and eslint config for App right now, but I'll leave specific electron eslint configs as is and let you take care of 2) |
Ok, agreed on all your points. Thanks for typing that out. re: bot vs git hook. Yeah con of bot is you have to pull down changes, but con of pre-commit hook is you have to wait for it to finish or (if it fails and you're impatient) you run --no-verify. I feel like it's an emacs vs vim thing. We can do whatever you want. I'll handle # 2, sounds like you are doing # 1. re: # 3 — squash or bust. (Why do you like rebase? I'm curious? I feel like it clutters commit history.) |
I'm going to close this issue. |
We have a baseline eslint and prettier config for the monorepo now.
app
will still probably need it's own eslint config to apply specificerb
rules it looks like, but we should work towards making the rules consistent with that in server & web. For example, let's work towards turning onno-explicit-any
andprefer-default-export
etcPrettier should be more straight forward. There'll be a big change of changing tabWidth from 4 to 2
The text was updated successfully, but these errors were encountered: