Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logging addon erases SPELLFAILCASTSELF and SPELLFAILPERFORMSELF strings, breaking the functionality of many other addons [vanilla] #25

Open
balakethelock opened this issue Jan 6, 2024 · 0 comments

Comments

@balakethelock
Copy link
Contributor

balakethelock commented Jan 6, 2024

Some addons like chronometer and the whole ace library SpellStatus rely on the event CHAT_MSG_SPELL_FAILED_LOCALPLAYER that fires when the player fails to cast a spell to print a message with that spell's name in chat.

The logging addon replaces these messages with info needed to fill player armory pages, and when it's done with that info it replaces them with NONE.

I suggest that instead of replacing it completely, the addon keeps the original "you fail to perform %s" spell and concatenates the necessary info for its logs after it.

Then the combatlog parser can be changed to simply ignore the first part of that message

Screenshots to clarify the image:
With the log addon
image

Without it
image

How it can be made more convenient for the logger:
You fail to perform whirlwind: Not Enough Rage. CONSOLIDATED: ZONE_INFO... etc
The website's parser can then just ignore everything before the first period of the string.

I'd highly appreciate if this gets implemented, the number one reason that makes people dislike doing logs is it bugs out a lot of their addons that they use to track their debuff timers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant