Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical security issue. #87

Open
Legend-of-iPhoenix opened this issue Mar 23, 2018 · 2 comments
Open

Critical security issue. #87

Legend-of-iPhoenix opened this issue Mar 23, 2018 · 2 comments
Assignees
@Legend-of-iPhoenix
Labels
bug Something isn't working critical Prevents normal usage of TheButton for some or all users, or something that needs top priority.

Comments

@Legend-of-iPhoenix
Copy link
Owner

Legend-of-iPhoenix commented Mar 23, 2018 •
edited

You can alter peoples' high scores by injecting a small script into the chrome console. I'm currently fixing this issue by doing a partial restructure of the DB and entirely reworking our firebase database rules.

TheButton has been disabled temporarily.
@Legend-of-iPhoenix Legend-of-iPhoenix added bug Something isn't working critical Prevents normal usage of TheButton for some or all users, or something that needs top priority. labels Mar 23, 2018
@Legend-of-iPhoenix Legend-of-iPhoenix self-assigned this Mar 23, 2018
@Legend-of-iPhoenix
Copy link
Owner Author

I have done a bit of work. I'll probably hold a closed beta of the changes with some of the more frequent contributors. @ticalc-travis and @jcgter777, namely.

@josheewa
Copy link
Contributor

@Legend-of-iPhoenix Are there any important significant changes in anything that I need to copy over to my repo? I have lots of different stuff, in the html, js, and css. If there are any things I HAVE to copy over, I need to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Legend-of-iPhoenix Legend-of-iPhoenix

Labels
bug Something isn't working critical Prevents normal usage of TheButton for some or all users, or something that needs top priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Legend-of-iPhoenix @josheewa