Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diancie/Hoopa/Volcanion #3

Closed
Snowysauce opened this issue Oct 3, 2016 · 4 comments
Closed

Diancie/Hoopa/Volcanion #3

Snowysauce opened this issue Oct 3, 2016 · 4 comments
Labels

Comments

@Snowysauce
Copy link
Collaborator

In the Pokémon species dropdown list, Diancie's name is misspelled as "Diance". (This is referring to the standard entry for Diancie; the Mega Evolution entry is spelled correctly.)

Also, the Pokédex numbers for Hoopa (standard entry) and Volcanion are reversed in the dropdown list's code. Volcanion is listed as #720, and Hoopa is listed as #721. #720 should be Hoopa; #721 should be Volcanion. Although the calculator works fine for both Pokémon, the error causes the wrong sprite to show when either Pokémon is selected.

@Arty2
Copy link
Collaborator

Arty2 commented Oct 4, 2016

Thanks! Will fix as soon as possible : )

@Arty2 Arty2 added the bug label Oct 4, 2016
@Snowysauce
Copy link
Collaborator Author

I fixed the Diancie typo as part of my pull request for issue #4. I didn't edit Hoopa or Volcanion since that change also requires edits to the compressed Pokémon stat data.

@Arty2
Copy link
Collaborator

Arty2 commented Oct 6, 2016

Excellent, thank you, will merge asap :)

@Snowysauce
Copy link
Collaborator Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants