Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bugs, problems, and requests #17

Open
4 of 6 tasks
critor opened this issue Mar 20, 2016 · 2 comments
Open
4 of 6 tasks

Search bugs, problems, and requests #17

critor opened this issue Mar 20, 2016 · 2 comments
Assignees

Comments

@critor
Copy link
Contributor

critor commented Mar 20, 2016

  • Because of the dialog box, when performing a seach the display gets altered and becomes dirty.
    But if nothing is found, the display doesn't get refreshed. So it remains dirty, and the user doesn't know that the search has ended.
  • Although we can easily input them with the flag/book keys, special characters (letters with an accent for example) aren't found, even when present in the document.
  • Search results don't seem to get reset properly. They are still partially present when performing several searches in a row on the same document, and interfere with the results display (if a text display is inverted twice, then it gets normal again...)
  • When a search result is not visible on the screen, the page doesn't scroll automatically.
  • If we don't release it very fast, typing Ctrl+F does input F in the dialog box, which then has to be deleted each time.
  • Any way to have the search scan all the pages and not only the current one ?

In all cases, thanks for this new promising feature. :)

@Legimet
Copy link
Owner

Legimet commented Apr 12, 2016

"Although we can easily input them with the flag/book keys, special characters (letters with an accent for example) aren't found, even when present in the document."

This appears to be a bug in libndls. I made a PR to the Ndless repo: ndless-nspire/Ndless#32.

@Legimet
Copy link
Owner

Legimet commented Apr 12, 2016

Since the PR was merged, special character searches now work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants