BREAKING: Change config format on minimal-blog theme #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
type: enhancement
LekoArts
added a commit
that referenced
this pull request
Jan 23, 2020
* Remove unused navigation hook * Replace hooks * New config hooks * Move config in siteMetadata to own config * Add README notices
LekoArts
added a commit
that referenced
this pull request
Jan 23, 2020
* Remove unused navigation hook * Replace hooks * New config hooks * Move config in siteMetadata to own config * Add README notices BREAKING CHANGE: The navigation and externalLinks options are no longer on the siteMetadata but now in the theme options itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232
Coming from the above mentioned issue I quickly realized while reproducing the bug that:
siteMetadatalike with theme options itselfSo I decided to move the config options into the theme options and a
MinimalBlogConfigtype. I do the same with myemiliatheme.I also made
navigationandoptionalLinksoptional (by adding checks to the components) so you can actually leave both empty now if you want to have a one-page for example.Unfortunately I thought while creating this theme that
siteMetadatawould be sufficient but I've been wrong. Hence these drastic changes that are definitely breaking changes.As an end-user you'll need to move the options to the theme options and should be good to go (if you haven't shadowed any affected components)