fix(deps): make theme-ui a peerDependency #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to solve package resolution issues.
|
Awesome, thank you for the response! 😊 |
LekoArts
added a commit
that referenced
this pull request
Apr 27, 2020
Theme UI updated to v0.3 a while ago and I now finally had time to go through the breaking changes: https://theme-ui.com/migrating#v03 In general this update should be painless and without any breaking changes (for most people). The sites look and function identical, it was more a technical refactoring. ## Breaking Changes These changes might be breaking for some people: - `@lekoarts/gatsby-theme-specimens`: Renamed the `theme` prop on the `<Heading />` component to `config` - `@lekoarts/gatsby-theme-specimens` & `@lekoarts/gatsby-theme-styleguide`: Removed `theme-ui` as a direct dependency and moved them to `peerDependencies`. This supersedes the PR #262 ## Description - Updated all `gatsby`, `react`, `react-dom` packages to latest version - Removed `@emotion/core` and `@mdx-js/react` packages as `theme-ui` now comes with it - Removed `<Styled.root />` components as Theme UI now places that on the `body` by default - Replaced `Styled.x` with e.g. `Link`, `Heading` - Moved `@emotion/core`, `@mdx-js/mdx` & `@mdx-js/react` to `yarn resolutions` to only have one version of each dependency - Use `merge` from `theme-ui` for config merging - Clean up `<Global />` by moving stuff to the Theme UI config - Rename some internal TypeScript types - Add/Update some comments - Use optional chaining.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve package resolution issues.