Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mp_menu_glare #43

Closed
Oszoou opened this issue Sep 15, 2021 · 3 comments
Closed

Add mp_menu_glare #43

Oszoou opened this issue Sep 15, 2021 · 3 comments
Labels
priority: p3 low A cosmetic bug or a new feature request status: won't fix This is not a bug, so it won't be fixed type: feature request Request to implement a specific feature

Comments

@Oszoou
Copy link

Oszoou commented Sep 15, 2021

Add menu glare like in CitizenFX port of NativeUI.

image

@justalemon justalemon added priority: p3 low A cosmetic bug or a new feature request status: acknowledged We are aware of the bug or feature request type: feature request Request to implement a specific feature labels Sep 15, 2021
@justalemon justalemon added this to the 1.6 milestone Sep 15, 2021
@justalemon justalemon modified the milestones: 1.6, 1.7 Nov 21, 2021
@justalemon justalemon modified the milestones: 1.7, 1.6 Dec 13, 2021
@WithLithum
Copy link

I do not know if you have already done this but I decompiled mp_menu_glare and found these parameters of SET_DISPLAY_CONFIG function:

  • _screenWidthPixels - A number, the screen resolution width in pixels (used for calculating)
  • _screenHeightPixels - A number, the screen resolution height in pixels (used for calculating)
  • _safeTopPercent, _safeBottomPercent, _safeLeftPercent, _safeRightPercent - A percentage number used for calculation (safezone)
  • _isWideScreen - Boolean, as it's name to determine whether widescreen
  • _isHiDef - Boolean
  • _isAsian - Probably unused (didn't see it in the method body)

@justalemon
Copy link
Member

_isWideScreen - Boolean, as it's name to determine whether widescreen

@WithLithum Do you know by any chance what this does exactly?

@justalemon justalemon removed this from the 1.6 milestone Dec 22, 2021
@justalemon
Copy link
Member

After playing for a couple of hours, I found that you can't draw the MP_MENU_GLARE scaleform via DRAW_SCALEFORM_MOVIE, only via DRAW_SCALEFORM_MOVIE_FULLSCREEN.

It appears that one of the custom memory patches that FiveM does might have contributed to getting DRAW_SCALEFORM_MOVIE to work as on SP via SHV, you can't use that function with the glare scaleform.

If someone finds a way to draw this scaleform at a custom position, feel free to post a comment here and Ill reopen the issue.

@justalemon justalemon added status: won't fix This is not a bug, so it won't be fixed and removed status: acknowledged We are aware of the bug or feature request labels Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 low A cosmetic bug or a new feature request status: won't fix This is not a bug, so it won't be fixed type: feature request Request to implement a specific feature
Projects
None yet
Development

No branches or pull requests

3 participants