Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fava terminal created regardless of runFavaOnActivate #77

Closed
fancl20 opened this issue Oct 18, 2022 · 2 comments
Closed

Fava terminal created regardless of runFavaOnActivate #77

fancl20 opened this issue Oct 18, 2022 · 2 comments

Comments

@fancl20
Copy link

fancl20 commented Oct 18, 2022

Fava terminal is created in the constructor of FavaManager:

  constructor(extension: Extension) {
    this._terminal = vscode.window.createTerminal('Fava');
    this._terminalClosed = false;
    this.extension = extension;
  }

IIUC, this will create a Fava terminal even runFavaOnActivate is set to false. Maybe we can set the terminal to close by default?
@Lencerf
Copy link
Owner

Lencerf commented Oct 24, 2022

fixed in f8af0cc

@fancl20
Copy link
Author

fancl20 commented Oct 24, 2022

Verified. Thanks!

@fancl20 fancl20 closed this as completed Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fancl20 @Lencerf