Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out npm, merging fork, etc #2

Closed
lhl opened this issue Feb 5, 2016 · 4 comments
Closed

Figure out npm, merging fork, etc #2

lhl opened this issue Feb 5, 2016 · 4 comments

Comments

@lhl
Copy link
Member

lhl commented Feb 5, 2016

Hey @ntheile - was trying to figure out how to reach out. Thanks for packaging/updating my plugin and putting it in the npm registry - https://www.npmjs.com/package/phonegap-sharedimage

I've merged your changes, also merged a fix - your release had an extra space that broke everything. I've also give you write access to the original repo here.

I'm actively using this plugin again btw, don't mind helping w/ maintenance. Do you want add me as an npm owner / pointing to this repo?

@ntheile
Copy link

ntheile commented Feb 5, 2016

Hi @lhl . - It looks like the npm package was tied to my fork of your code at github.com/ntheile/phonegap-sharedimage . I am no longer actively working on this project and just did a quick proof of concept using phonegap build and needed to use npm for that to work. I'll delete the npm package so you can get the phonegap-sharedimage namespace and associate it to your github code.

@lhl
Copy link
Member Author

lhl commented Feb 5, 2016

Sweet, thx. I've updated now and giving the plugin some love now (so that it'll work w/ modern Cordova).

@lhl lhl closed this as completed Feb 5, 2016
@lhl
Copy link
Member Author

lhl commented Feb 5, 2016

btw @ntheile did you ever get this working w/ modern Cordova? futzing w/ it in Cordova 6 and intents aren't showing up. I'll get to the bottom of it in the next day or two but if you had this working, would love to hear what's up.

@ntheile
Copy link

ntheile commented Feb 6, 2016

i dont really remember... i had to get pretty native with some of the camera settings, so i ended up using xamarin forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants