Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom inset problem with 2.10.6 #406

Closed
MacMark opened this issue Sep 2, 2020 · 3 comments
Closed

Bottom inset problem with 2.10.6 #406

MacMark opened this issue Sep 2, 2020 · 3 comments

Comments

@MacMark
Copy link

MacMark commented Sep 2, 2020

I'm having some layout problems like with earlier version of 2.10.x (before 2.10.5): The bottom of the view controller behind the popup bar is covered by the popup bar when the navigation bar on top is hidden. In this screenshot 1 and a half row of the table are hidden by the popup bar which was not the case with 2.10.5

This is 2.10.6:
image

And that is 2.10.5:
image

I would like to have the correct layout behavior of 2.10.5 😊

Originally posted by @MacMark in #397 (comment)

@LeoNatan
Copy link
Owner

LeoNatan commented Sep 2, 2020

I'm unable to reproduce.

In your view controller, implement - (void)viewSafeAreaInsetsDidChange and print the view.safeAreaInsets before and after presentation. If you see the safe area insets update correctly, you must be mismanaging your scroll view insets.

@MacMark
Copy link
Author

MacMark commented Sep 3, 2020

You're right. I found this old hack on my side which was necessary before but is not needed any longer in the affected view controllers 😇

//hack for fixing wrong adjustedContentInset
    if (AppDelegate.tabBarController.stickyPlayer) {
        insets.bottom = -AppDelegate.tabBarController.stickyPlayer.view.frame.size.height;
    }

I removed that and it works with 2.10.6. Thanks for your feedback.

@LeoNatan LeoNatan closed this as completed Sep 3, 2020
@LeoNatan
Copy link
Owner

LeoNatan commented Sep 3, 2020

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants