Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Deprecate AsyncTask. Add RxJava variant of TextCrawler.makePreview() #40

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dhruvnagarajan
Copy link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Add RxJava variant of makePreview() to TextCrawler
  • Refactor
  • Move crawler network call and parsing logic to an abstraction
  • Move async task implementation to a separate class
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • TextCrawler.extendedTrim(String) requires reference via TextCrawler.Companion.extendedTrim(String), when called from Java.
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

- Move Textcrawler.getSourceCode to a new abstraction
- Add RxJava to :library and :app
- Add kotlin to :library
- Update getSourceCode AsyncTask return type
@dhruvnagarajan dhruvnagarajan changed the title Add RxJava variant of TextCrawler.makePreview() Deprecate AsyncTask. Add RxJava variant of TextCrawler.makePreview() Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant