Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

Meta Tag Handling Improvements #8

Merged
merged 1 commit into from Apr 14, 2016

Conversation

jdonmoyer
Copy link
Contributor

  • Add performance improvement to only convert meta tag match to lowercase once in the for loop
  • Add an updateMetaTag method that will only store the meta tag value if it is non-null and non-empty; This fixed issues where bad descriptions were being pulled in cases where multiple 'description' meta tags were found and the last one had no value. See www.fandango.com for an example case where this occurs.

- Add performance improvement to only convert meta tag match to lowercase once in the for loop
- Add an updateMetaTag method that will only store the meta tag value if it is non-null and non-empty;  This fixed issues where bad descriptions were being pulled in cases where multiple 'description' meta tags were found and the last one had no value.  See www.fandango.com for an example case where this occurs.
@LeonardoCardoso LeonardoCardoso merged commit 11a8f19 into LeonardoCardoso:master Apr 14, 2016
@jdonmoyer jdonmoyer deleted the use-meta-data branch September 13, 2018 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants