Fix for youtube url fetch metadata issue #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nafis042 Thanks. I will test it ASAP. |
kodekarim
reviewed
Jan 28, 2021
There was a problem hiding this comment.
@nafis042 , thanks for the PR really helped me a lot, it's working for YouTube but not working with Instagram video
link - https://www.instagram.com/p/CKg_9H2gpQm/?utm_source=ig_web_copy_link
|
Instagram uses open graph tags and for this, I think new regex expressions must be included. I made a quick fix for the Instagram image tag but this should be handled properly for video, title, description as well. |
|
@nafis042 tested Insta link, working great |
|
@nafis042 @abdulKarim002 Cool! Thanks! I will have a look at it this weekend and push a new version. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes youtube url fetch metadata issue. adding just a user-Agent field in the request header fixes the issue. i don't think it will break anything. if anything breaks please comment here