Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some bit.ly Links causes the app to lag (until the url gets loaded) #32

Closed
kuyazee opened this issue Oct 13, 2016 · 6 comments
Closed

Comments

@kuyazee
Copy link

kuyazee commented Oct 13, 2016

I think this is some kind of small problem for the dispatch or thread, but I'm still not really adept at that part of coding so I don't know.

http://bit.ly/2dIBlR6 here's the link btw

But once again. This project is so kickass awesome. Thanks :)

@kuyazee kuyazee changed the title bit.ly Links causes the app to lag (until the url gets loaded) some bit.ly Links causes the app to lag (until the url gets loaded) Oct 13, 2016
@LeonardoCardoso
Copy link
Owner

Do you have more examples?

@kuyazee
Copy link
Author

kuyazee commented Oct 14, 2016

here's another one I found. (I think it's because the link redirects to a PDF)

http://bit.ly/2dKjZUz

btw is SwiftLinkPreview done synchronously?

@LeonardoCardoso
Copy link
Owner

To capture the real URL request is synchronous because we need to follow the redirections of a short url, but the rest is not.

@kuyazee
Copy link
Author

kuyazee commented Oct 17, 2016

really? cause even when I'm just trying to load links like www.github.com (I type in a textfield a link and I detect if the link is of the legit format then every tap I load it by adding a target to my textfield .EditingChanged)

so everytime I tap it tries to load (so it lags/delays a little bit) so I changed loading of url's to textField didEndEditing

@LeonardoCardoso
Copy link
Owner

LeonardoCardoso commented Feb 22, 2017

Can you try it with the new version?

@LeonardoCardoso
Copy link
Owner

Closed due inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants