ensure that parser is closed when parsing a string, to guarantee well…

… formed but not closed XML generates an error
Leonidas-from-XIV · Dec 6, 2013 · 8d1a9a6 · 8d1a9a6
1 parent 23b4776
commit 8d1a9a6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/lib/xml2js.js b/lib/xml2js.js
diff --git a/src/xml2js.coffee b/src/xml2js.coffee
@@ -299,7 +299,7 @@ class exports.Parser extends events.EventEmitter
       @emit "end", null
       return true
 
-    @saxParser.write bom.stripBOM str.toString()
+    @saxParser.write(bom.stripBOM str.toString()).close()
 
 exports.parseString = (str, a, b) ->
   # let's determine what we got as arguments

diff --git a/test/parser.test.coffee b/test/parser.test.coffee
@@ -285,8 +285,10 @@ module.exports =
         throw new Error 'error throwing in callback'
       throw new Error 'error throwing outside'
     catch e
-      # don't catch the exception that was thrown by callback
+      # the stream is finished by the time the parseString method is called
-      equ e.message, 'error throwing outside'
+      # so the callback, which is synchronous, will bubble the inner error
+      # out to here, make sure that happens
+      equ e.message, 'error throwing in callback'
       test.finish()
 
   'test xmlns': skeleton(xmlns: true, (r) ->
@@ -340,3 +342,9 @@ module.exports =
         equ err, null
         assert.deepEqual resWithNew, resWithoutNew
         test.done()
+
+  'test not closed but well formed xml': (test) ->
+    xml = "<test>"
+    xml2js.parseString xml, (err, parsed) ->
+      assert.equal err.message, 'Unclosed root tag\nLine: 0\nColumn: 6\nChar: '
+      test.finish()