Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when used with Dist::Zilla::Plugin::FatPacker due to Compiler::Lexer #4

Closed
xsawyerx opened this issue Jan 10, 2017 · 4 comments

Comments

@xsawyerx
Copy link

Compiler::Lexer has a bug which is triggered when this plugin is used along with Dist::Zilla::Plugin::FatPacker (correlating bug report).

Compiler::Lexer does not seem maintained (no code changes or releases for over 2 years), but I do believe this might be fixed by the way either this plugin or FatPacker plugin is implemented, which probably trigger each other by accident.

@Leont
Copy link
Owner

Leont commented Jan 11, 2017

I don't know enough about Compiler::Lexers internals to say anything about what's going on. A backtrace may be helpful though.

Does the same thing happen when running Perl::MinimumVersion::Fast on the fatpacked file? In that case it's not my plugin that's at fault (it's simple enough that that seems unlikely). The most logical explanation would be that it pukes over some unusual input, in which case knowing what module it trips over would be useful knowledge. I'm not sure if there's a more efficient way of figuring this out than trial-and-error.

@xsawyerx
Copy link
Author

This is not a bug with the plugin, but with Compiler::Lexer which can be verified regardless of this plugin or Perl::MinimumVersion::Fast.

Feel free to close the bug if you think it's irrelevant to note.

@Code-Hex
Copy link

Code-Hex commented Jan 2, 2018

Hello, @xsawyerx @Leont
While exchanging of opinions with the author at the backside, I'm trying now to contribute to Compiler::Lexer.
It will be helpful if you let me know details what content of a file you loaded to Compiler::Lexer.

Thanks.

@xsawyerx
Copy link
Author

xsawyerx commented Jan 2, 2018

I cannot recreate the failure so I'm closing all related issues.

@xsawyerx xsawyerx closed this as completed Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants