Deal better with copy-on-write

Leont · Dec 8, 2012 · c47ceb2 · c47ceb2
1 parent 1b76bb0
commit c47ceb2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 Revision history for File-Map
 
 {{$NEXT}}
+          Deal better with copy-on-write
           Remove Const::Fast dependency
 
 0.53      2012-11-07 11:45:09 Europe/Amsterdam

diff --git a/lib/File/Map.xs b/lib/File/Map.xs
@@ -213,6 +213,7 @@ static void mmap_fixup(pTHX_ SV* var, struct mmap_info* info, const char* string
 
 	if (string && len)
 		Copy(string, info->fake_address, MIN(len, info->fake_length), char);
+	SV_CHECK_THINKFIRST_COW_DROP(var);
 	if (SvROK(var))
 		sv_unref_flags(var, SV_IMMEDIATE_UNREF);
 	if (SvPOK(var))
@@ -341,7 +342,7 @@ static Off_t S_sv_to_offset(pTHX_ SV* var) {
 static void check_new_variable(pTHX_ SV* var) {
 	if (SvTYPE(var) > SVt_PVMG && SvTYPE(var) != SVt_PVLV)
 		Perl_croak(aTHX_ "Trying to map into a nonscalar!\n");
-	SV_CHECK_THINKFIRST(var);
+	SV_CHECK_THINKFIRST_COW_DROP(var);
 	if (SvREADONLY(var))
 		Perl_croak(aTHX_ "%s", PL_no_modify);
 	if (SvMAGICAL(var) && mg_find(var, PERL_MAGIC_uvar))