Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Connection Errors #76

Open
mdpenguin opened this issue Jan 12, 2024 · 1 comment
Open

Handle Connection Errors #76

mdpenguin opened this issue Jan 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mdpenguin
Copy link

Bug description

Feature request:

Please add handling when the request to the Adobe servers cannot be fulfilled

Current behavior:

When a server error occurs (e.g. 404 or 403), Calibre imports the ACSM file directly without stating why the plugin could not retrieve the ebook

Expected behavior:

Do not import ACSM file and throw a descriptive error message when unable to fulfill request with Adobe server.
It would also be helpful to log to the job queue, as requested in #61.

Operating system

Linux

Which version of Calibre are you running?

6.29

Which version of the ACSM Input plugin are you running?

v0.0.16

Import type

Clicking the 'Add books' button in the menu bar

Further information

No response

@Leseratte10
Copy link
Owner

I'd love to add that feature, but it's not that easy.

There's no API in Calibre for a FileType plugin to return any error message or show any error dialog box on import. All a file type plugin can (and must) return to Calibre is a file - either an EPUB or PDF on success or the ACSM on failure.

Same as for the job queue, the FileType plugin would somehow need to signal to the GUI plugin to pop up an error message.

Some time in the future I'll hopefully have some more time to look into all this.

@Leseratte10 Leseratte10 added the enhancement New feature or request label Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants