Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: planned breaking changes in v2 #47

Closed
15 tasks done
vweevers opened this issue Nov 4, 2022 · 3 comments
Closed
15 tasks done

Tracking issue: planned breaking changes in v2 #47

vweevers opened this issue Nov 4, 2022 · 3 comments
Labels
discussion Discussion semver-major Changes that break backward compatibility
Milestone

Comments

@vweevers
Copy link
Member

vweevers commented Nov 4, 2022

In order of significance:

These won't necessarily land in a single major version. I wanted a place to list them and allow people to object.

@vweevers vweevers added semver-major Changes that break backward compatibility discussion Discussion labels Nov 4, 2022
@vweevers vweevers added this to the 2.0.0 milestone Nov 5, 2022
@vweevers
Copy link
Member Author

vweevers commented Nov 6, 2022

I did a quick test on memory-level, replacing _put(key, value, options, callback) with async _put(key, value, options). As a result, await db.put(key, value) is 2x faster!

$ level-bench plot put
benchmark put on memory-level@1.0.0 win32 x64
node@16.9.1 n=1M concurrency=4 valueSize=100B keys=random values=random

1  memory-level#v2    69565 ops/s ±8.83%  fastest
2  memory-level#main  33750 ops/s ±8.07%  +51.14%

@vweevers
Copy link
Member Author

Removed a bunch of items from the list above, to keep the release manageable (see v2/UPGRADING.md for current content).

@vweevers
Copy link
Member Author

Done; remaining items can go into a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion semver-major Changes that break backward compatibility
Projects
Status: Done
Development

No branches or pull requests

1 participant