Don't wrap existing errors #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that when `abstract-leveldown` starts using `level-errors`, and
such a db is wrapped with `levelup`, `levelup` will not rewrap
errors and lose stack trace information in the process. I.e.:
```
// Error created by abstract-leveldown
const err = new ReadError('example')
// Error created by levelup
const wrapped = new ReadError(err)
assert(wrapped === err)
```
Ref Level/community#58
juliangruber
previously requested changes
Sep 19, 2021
vweevers
commented
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that when
abstract-leveldownstarts usinglevel-errors, and such a db is wrapped withlevelup,levelupwill not rewraperrors and lose stack trace information in the process. I.e.:
Initially I wanted to do this in
errno, but I want more flexibility than what would be right forerrno, specifically, comparing errors by their.typeinstead of withinstanceof. In addition, I found some bugs inerrnoandprr, of which the latter is archived, so I figured inlining (a subset oferrno) would be easier. Also results in less code overall. To see those bugs, review this PR commit by commit.There's technically a breaking change here: errors are no longer an instanceof CustomError, but I consider that an internal detail.
Ref Level/community#58.