Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy with location and prefix only #116

Merged
merged 3 commits into from
May 27, 2018
Merged

Destroy with location and prefix only #116

merged 3 commits into from
May 27, 2018

Conversation

ralphtheninja
Copy link
Member

Closes #114

@ralphtheninja ralphtheninja added this to Backlog in Level (old board) via automation May 27, 2018
@ralphtheninja ralphtheninja moved this from Backlog to Review in Level (old board) May 27, 2018
vweevers
vweevers approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@vweevers
Copy link
Member

Side note: let's add tests for prefix.

@vweevers
Copy link
Member

#117

@ralphtheninja ralphtheninja merged commit c06cac7 into master May 27, 2018
Level (old board) automation moved this from Review to Done May 27, 2018
@ralphtheninja ralphtheninja deleted the destroy branch May 27, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralphtheninja @vweevers