Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test/levelup-test.js #134

Merged
merged 1 commit into from
May 28, 2018
Merged

Remove test/levelup-test.js #134

merged 1 commit into from
May 28, 2018

Conversation

ralphtheninja
Copy link
Member

Closes #96

@ralphtheninja ralphtheninja added this to Backlog in Level (old board) via automation May 27, 2018
@ralphtheninja ralphtheninja moved this from Backlog to Review in Level (old board) May 27, 2018
@ralphtheninja
Copy link
Member Author

Also see Level/level-browserify#47

@vweevers
Copy link
Member

We can also rewrite the destroy tests to not use levelup. This:

level-js/test/custom-test.js

Line 168 in 2666a50

test('test levelup .destroy', function (t) {

And

level-js/test/custom-test.js

Line 191 in 2666a50

test('test levelup .destroy and custom prefix', function (t) {

Then we can remove the levelup dependency as well as the pinkie Promise polyfill.

@vweevers vweevers merged commit 249f3e8 into master May 28, 2018
Level (old board) automation moved this from Review to Done May 28, 2018
@vweevers vweevers deleted the remove-levelup-tests branch May 28, 2018 08:06
@vweevers vweevers mentioned this pull request May 28, 2018
Closed
@ralphtheninja
Copy link
Member Author

@vweevers Yes, let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers vweevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralphtheninja @vweevers