Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize range options of compactRange() #499

Closed
vweevers opened this issue Jul 22, 2018 · 0 comments
Closed

Serialize range options of compactRange() #499

vweevers opened this issue Jul 22, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@vweevers
Copy link
Member

leveldown/leveldown.js

Lines 64 to 66 in 819946c

LevelDOWN.prototype.compactRange = function (start, end, callback) {
this.binding.compactRange(start, end, callback)
}

We should do the same as in approximateSize():

leveldown/leveldown.js

Lines 58 to 61 in 819946c

start = this._serializeKey(start)
end = this._serializeKey(end)
this.binding.approximateSize(start, end, callback)

@vweevers vweevers added the bug Something isn't working label Jul 22, 2018
@vweevers vweevers added this to Backlog in Level (old board) via automation Jul 22, 2018
@vweevers vweevers moved this from Backlog to In progress in Level (old board) Oct 20, 2018
@vweevers vweevers moved this from In progress to Review in Level (old board) Nov 24, 2018
Level (old board) automation moved this from Review to Done Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant