Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .npmignore due to snappy changes #534

Closed
ralphtheninja opened this issue Nov 11, 2018 · 4 comments
Closed

Update .npmignore due to snappy changes #534

ralphtheninja opened this issue Nov 11, 2018 · 4 comments

Comments

@ralphtheninja
Copy link
Member

See Level/rocksdb#80 (comment)

We get the testdata folder in the tarball now and unpacked it's 2.9Mb.

@ralphtheninja ralphtheninja added this to Backlog in Level (old board) via automation Nov 11, 2018
@filoozom
Copy link
Contributor

Would updating .npmignore actually work for Git Submodules? If npm simply runs git submodule -q update --init --recursive, then I wouldn't count on npm to delete files from the git repo, but I guess I should test that first.

This also means that this package now depends on git, which you initially didn't want if I remember correctly. I thought we pushed the whole source code to npm. Maybe ignoring .gitmodules could work?

And if we actually depend on git now, then we might as well only fetch Submodules if the library needs to be built and can't use prebuild packages.

@ralphtheninja
Copy link
Member Author

Would updating .npmignore actually work for Git Submodules?

Well, primarily it's for publishing to npm so we don't publish the testdata folder.

This also means that this package now depends on git, which you initially didn't want if I remember correctly.

No, we don't depend on git. Why would this be the case?

@filoozom
Copy link
Contributor

Maybe I misunderstood something, but based on the conversation in Level/rocksdb#80 I assumed that npm ran git after install as opposed to on prepublish, which might not be the case. Did you publish a test version on npm with Git Submodules?

@vweevers
Copy link
Member

Maybe I misunderstood something, but based on the conversation in Level/rocksdb#80 [..]

That conversation was about npm i Level/leveldown rather than the usual npm i leveldown (which does not need git).

Level (old board) automation moved this from Backlog to Done Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants