Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iOS prebuild #626

Closed
5 tasks
vweevers opened this issue Apr 27, 2019 · 2 comments
Closed
5 tasks

Add iOS prebuild #626

vweevers opened this issue Apr 27, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed stale This issue or pull request is old

Comments

@vweevers
Copy link
Member

Forked from #575. Exact details TBD. At the very least, we need to:

  • Have people that are qualified to review and test
  • Decide whether to use the nodejs-mobile(-gyp) forks or node core. I prefer the latter because I don't want us to get stuck with nodejs-mobile. Someone must step up and champion it. Node 12 updated to V8 7.4 which introduced an interpreter-only mode, so in theory node can support iOS now (to my limited understanding).
  • Add a separate Travis job (using OSX?)
    • If nodejs-mobile: set PREBUILD_NODE_GYP=nodejs-mobile-gyp
  • Find out what the value of os.platform() is; node-gyp-build must be able to detect iOS.
@vweevers vweevers added enhancement New feature or request help wanted Extra attention is needed labels Apr 27, 2019
@vweevers vweevers added this to Backlog in Level (old board) via automation Apr 27, 2019
@vweevers vweevers mentioned this issue Apr 27, 2019
Merged
@vweevers
Copy link
Member Author

vweevers commented Oct 5, 2019

Removing this from the backlog because there's no actionable item for us. As noted above we need external help.

@vweevers vweevers removed this from Backlog in Level (old board) Oct 5, 2019
@vweevers vweevers mentioned this issue Aug 3, 2020
Closed
@vweevers vweevers added the stale This issue or pull request is old label Dec 8, 2021
@vweevers
Copy link
Member Author

vweevers commented Dec 8, 2021

Can reopen if there's interest and someone to champion it.

@vweevers vweevers closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed stale This issue or pull request is old
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vweevers