Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace or take over maintenance of du, delayed and readfiletree #633

Closed
vweevers opened this issue May 20, 2019 · 4 comments
Closed

Replace or take over maintenance of du, delayed and readfiletree #633

vweevers opened this issue May 20, 2019 · 4 comments
Labels
maintenance General maintenance
Projects
Level (old board)

Comments

@vweevers
Copy link
Member

No description provided.

@vweevers vweevers added the maintenance General maintenance label May 20, 2019
@vweevers vweevers added this to Backlog in Level (old board) via automation May 20, 2019
@vweevers vweevers changed the title Replace or take over maintenance of du, delayed, mkfiletree and readfiletree Replace or take over maintenance of du, delayed and readfiletree Jun 22, 2019
@rvagg
Copy link
Member

rvagg commented Jun 23, 2019

fixed by #649, #648, #647, they've come out of retirement

@vweevers
Copy link
Member Author

Great. Should you need help maintaining these now or in the future, I'm willing.

As for delayed, which we only use here, we can replace that with an inline setTimeout() call, if we even still need a timeout.

@rvagg
Copy link
Member

rvagg commented Jun 23, 2019

Ah, right, delayed@2.0.0 published, incoming via greenkeeper. Can be done without pretty easily but I always had a bit of a sweet spot for that package, especially its debouncer.

@vweevers
Copy link
Member Author

vweevers commented Jun 23, 2019 •
edited

Alright, we'll keep it, no need to refactor code that has worked for years.

I'm opening a PR though to fix a small bug I just found in that compression test. => #651

Level (old board) automation moved this from Backlog to Done Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance General maintenance
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rvagg @vweevers