Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prebuildify-cross #694

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Use prebuildify-cross #694

merged 1 commit into from
Nov 17, 2019

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Nov 17, 2019 •
edited
Loading

Which has been rewritten, see prebuild/prebuildify-cross#7. It's a github dependency for now; waiting for npm ownership.

In addition, CentOS & Alpine prebuilds are now built together in one Travis job. Simplifies the matrix.

@vweevers
Use prebuildify-cross
95c1e34 
Which has been rewritten, see prebuild/prebuildify-cross#7.

It's a github dependency for now; waiting for npm ownership.
@vweevers vweevers added semver-patch Bug fixes that are backward compatible refactor Requires or pertains to refactoring labels Nov 17, 2019
@vweevers vweevers added this to Review in Level (old board) Nov 17, 2019
@vweevers
Copy link
Member Author

All good.

$ file prebuilds/*/*
prebuilds/linux-x64/node.napi.glibc.node: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=85491e89fa227f9012749aee0a6c980438605e4c, stripped
prebuilds/linux-x64/node.napi.musl.node:  ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, stripped
prebuilds/darwin-x64/node.napi.node: Mach-O 64-bit bundle x86_64
prebuilds/android-arm64/node.napi.armv8.node: ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped
prebuilds/android-arm/node.napi.armv7.node:   ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, stripped
prebuilds/linux-arm64/node.napi.armv8.node:   ELF 64-bit LSB shared object, ARM aarch64, version 1 (SYSV), dynamically linked, stripped
prebuilds/linux-arm/node.napi.armv7.node:     ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, stripped

@vweevers vweevers merged commit b9513aa into master Nov 17, 2019
Level (old board) automation moved this from Review to Done Nov 17, 2019
@vweevers vweevers deleted the prebuildify-cross branch November 17, 2019 19:32
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralphtheninja ralphtheninja ralphtheninja approved these changes

Assignees
No one assigned
Labels
refactor Requires or pertains to refactoring semver-patch Bug fixes that are backward compatible
Projects
No open projects
Level (old board)
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vweevers @ralphtheninja