Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nyc and coveralls #459

Closed
ralphtheninja opened this issue Aug 29, 2017 · 9 comments
Closed

Add nyc and coveralls #459

ralphtheninja opened this issue Aug 29, 2017 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@ralphtheninja
Copy link
Member

ralphtheninja commented Aug 29, 2017

I've noticed that there are multiple code paths that aren't exercised during tests and I think we should add some coverage tool to help us figure out what needs to be tested.

What tools are there out there that we can use?

See level-ws.

@ralphtheninja ralphtheninja added enhancement New feature or request discussion Discussion labels Aug 29, 2017
@vweevers
Copy link
Member

nyc and/or coveralls?

@ralphtheninja ralphtheninja added the help wanted Extra attention is needed label Aug 29, 2017
@vweevers
Copy link
Member

vweevers commented May 5, 2018

The setup in memdown works well. If we add airtap to levelup, we get code coverage for free.

@ralphtheninja
Copy link
Member Author

@vweevers Could you clarify a bit? memdown uses istanbul for coverage.

@vweevers
Copy link
Member

vweevers commented May 5, 2018

Oops, you're right. Nevermind me, I mixed up some things. Let's pretend I said:

The setup in memdown works well. If we add istanbul to levelup, we get code coverage for free. 😸

@vweevers
Copy link
Member

vweevers commented May 5, 2018

But we should probably switch to nyc.

@ralphtheninja
Copy link
Member Author

@vweevers What about adding nyc to airtap and use airtap in levelup so we do get coverage for free? 😉

@vweevers
Copy link
Member

vweevers commented May 5, 2018

I like it better if those two are separated. If you want to combine code coverage of node tests and browser tests, nyc probably has to be separated (to encompass both suites).

@ralphtheninja
Copy link
Member Author

@vweevers Maybe code coverage could be our next "major" thing to focus on, once we have sauce labs running where applicable?

@vweevers
Copy link
Member

If that helps us on level-js, maybe. Short-term we can also collect code coverage manually, and fill the biggest gaps.

@ralphtheninja ralphtheninja moved this from Backlog to To Do in Level (old board) Jun 30, 2018
@ralphtheninja ralphtheninja changed the title add some sort of coverage tool Add nyc and coverals Jun 30, 2018
@ralphtheninja ralphtheninja changed the title Add nyc and coverals Add nyc and coveralls Jun 30, 2018
@ralphtheninja ralphtheninja moved this from To Do to In progress in Level (old board) Jun 30, 2018
@ralphtheninja ralphtheninja removed discussion Discussion help wanted Extra attention is needed labels Jun 30, 2018
@ralphtheninja ralphtheninja self-assigned this Jun 30, 2018
@ralphtheninja ralphtheninja moved this from In progress to Review in Level (old board) Jun 30, 2018
Level (old board) automation moved this from Review to Done Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants