Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream API change for 0.6: create*Stream() #77

Closed
rvagg opened this issue Feb 18, 2013 · 5 comments
Closed

stream API change for 0.6: create*Stream() #77

rvagg opened this issue Feb 18, 2013 · 5 comments
Labels
enhancement New feature or request

Comments

@rvagg
Copy link
Member

rvagg commented Feb 18, 2013

alias existing versions but rename to match Node core

@heapwolf
Copy link
Contributor

+1

1 similar comment
@juliangruber
Copy link
Member

+1

@juliangruber
Copy link
Member

well, I personally don't like the create, as Stream already says what is returned and that fact that it's a function is a clear hint that it creates a new stream rather than just returning one.

@luk-
Copy link

luk- commented Feb 18, 2013

+1 💯

@dominictarr
Copy link
Contributor

@juliangruber that is true, but this change makes it easier to remember, because it's the same as in node core.
of course, it's aliased, so you can still choose to use the old name.

@rvagg rvagg closed this as completed in e56f6a9 Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants