Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ubuntu 16.04 with CentOS 7 for prebuilds #153

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Nov 9, 2019

Using the new prebuildify-cross (prebuild/prebuildify-cross#7).

This makes the prebuilt binary for linux compatible with Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc.

Following Level/leveldown#674.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Nov 9, 2019
@vweevers vweevers added this to In progress in Level (old board) via automation Nov 9, 2019
@vweevers

This comment has been minimized.

@vweevers

This comment has been minimized.

This makes the prebuilt binary for linux compatible with Debian 8,
Ubuntu 14.04, RHEL 7, CentOS 7 and other flavors with an old glibc.

Following Level/leveldown#674. This rocksdb PR additionally uses
the new prebuildify-cross (prebuild/prebuildify-cross#7). That's a
github dependency for now; waiting for npm ownership.
@vweevers vweevers marked this pull request as ready for review November 16, 2019 17:21
@vweevers vweevers moved this from In progress to Review in Level (old board) Nov 16, 2019
@vweevers vweevers merged commit 6b2ebb7 into master Nov 17, 2019
Level (old board) automation moved this from Review to Done Nov 17, 2019
@vweevers vweevers deleted the prebuildify-cross branch November 17, 2019 19:32
@vweevers
Copy link
Member Author

5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant