Distribution

[Lewiscowles1986]

To push this forward there are a few points

• change owner? Separate repo? #8
• plugin repository submission?
• contributors update? Added composer.json, minor header changes, minor whitespacing #22
• guide RE: github updater please

[dmhendricks]

1. At minimum, I would recommend a more Composer- and WP-typical project slug and rename index.php to something descriptive.
2. I think that this is a good idea. Some considerations I might suggest first:
   • Add svgz MIME type??
   • Figure out a way to detect if other SVG plugins (such as Safe SVG or SVG Support) are installed and display a dismissible notice mentioning the redundancy and/or potential conflict? (not necessary, but might be nice) Detection would also be useful for theme/plugin authors that may with to use something like TGMPA to recommend/require your plugin be installed - they could avoid recommending it if something else already exists. I haven't looked into the best way to do this, but I suppose you could see if image/svg+xml exists in the MIME types list. This could probably be skipped and allow theme/plugin authors to take care of it, but as mentioned, it might be nice.
   • Think about limiting the scope of CSS? (see Limit CSS Scope? #24).
   • How do you feel about PHP 5.3+ support? I know that I personally/generally only support PHP 5.6+ (which itself is going to be EOL'd next month), but adding support for those sad souls who are stuck on 5.3-5.5 would be easy.
3. You're welcome to remove me as a contributor - there would be no hard feelings. I just added it there for shameless self-promotion. 😊
4. I can think about/work on that.

[Lewiscowles1986]

1. Sure I want to wait for feedback on this. I like the idea as direct access leads to nasty error on some shared hosts (I use one for testing).
2. Considerations
   • for this plugin svgz is fine. My worry is that it's a binary format. (should be separate issue)
   • Nice idea, this should be a separate issue, but I'm going to let someone else implement if they want. I do like the idea of cleaning the code (current code looks awful and shows how quickly I threw it together 😊). I suppose at-least it works.
   • Let's handle CSS Scope in Limit CSS Scope? #24
   • 5.3 (in-fact pre 5.6 now) won't be allowed. It's encouraging incompetence. Also a major point of actual rage between me and WP Core is that they are actively enabling bad practice.
3. was done in last commit 😉 👍
4. ⭐ 🌟 👍

[Lewiscowles1986]

any build distribution system should follow this advice afragen/git-updater#407 (comment)

[Lewiscowles1986]

After not addressing this for years, today GitHub actions was setup to deploy this using secrets, a fork of the 10up WordPress SVN deploy to allow for distributing src/ (probably should copy src to dist, more work if that is desired adding dist generated folder to git commit as it seems to be how it deploys)