Add an #InputLevel directive for controlling which generated inputs get ignored #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s get ignored. To avoid infinite loops and other side effects, AHK ignores self-generated input events. It does this by setting a sentinel value in the ExtraInfo field when sending input. In previous versions, a single sentinel value was used for all scripts, making it impossible for a script to send input that triggers a hotkey in another script. The #InputGroup directive provides a way to change the sentinel, so that each script only ignores input from the other scripts in the same input group.
Like the experimental #InputGroup directive, this allows control over which generated inputs get ignored. However, instead of working at the file level, this applies at the HotkeyVariant level like the #IfWinXXX directives. All hotkeys declared after the directive are assigned the specified InputLevel. Input generated at a given level can only trigger hotkeys that belong to a lower InputLevel. Input generated at level 0 cannot trigger any other hotkey since it is the lowest level. It is also the default level, which means the default behavior is exactly as in previous versions. TODO: - Rename from InputGroup to InputLevel. - Change the minimum InputLevel to 0. - Fix the default InputLevel sent by the hook. - Add a SendLevel command to change the SendLevel independently from the InputLevel
…evel (for generating input) - Change the min & max InputLevels to 0 and 100. - Change InputLevel & SendLevel to unsigned.
Now using the original KEY_IGNORE value (equivalent to KEY_IGNORE_BY_SENDLEVEL
at SendLevel 0) as the default for all generated input, and manually specifying
KEY_IGNORE_BY_SENDLEVEL where appropriate. This works much better because:
(a) KEY_IGNORE_BY_SENDLEVEL doesn't make sense in the context of the hook
(or anywhere else outside of a running AHK pseudo-thread), and using
it in such a way would compile fine but cause problems at runtime.
(b) It turns out the vast majority of calls that generate input are doing
so for side effects that should always be ignored at SendLevel 0 anyway.
TODO: Fix the hook to properly handle KEY_IGNORE_ALL_EXCEPT_MODIFIER_BY_SENDLEVEL
at SendLevels other than 0.
SendLevels other than 0. The fix ended up being to not support this mode in the first place. Based on the use cases this is designed for, any time we're sending input to be ignored at a given level, it will also make sense to update the state of the modifiers (i.e., exactly what KEY_IGNORE_ALL_EXCEPT_MODIFIER does). As an added bonus, limiting the scope like this allowed for simplification of some of the supporting code. This feature should now be functionally complete, with no known major issues.
set to the same as their #InputLevel, and other threads get the level of the last #InputLevel directive. The SendLevel action provides a way to set a different value during thread execution. This should rarely be needed for hotkey threads, and can result in infinite hotkey loops if not used carefully.
Move some of them to more appropriate header files.
…ed for both hotkeys and hotstrings.
hotstring's InputLevel.
|
Have you had a chance to look at this? Any thoughts on potentially merging it in? |
Fixes this bug: when sending something like ^a from an elevated SendLevel, the ctrl key would still be ignored at lower levels.
(A non-zero InputLevel only works when using the hook.)
|
Good work. Would you mind writing user documentation for the new features? As I mentioned via e-mail previously, commit 23049fa caused the merge to fail. I've since figured out that it had inconsistent line endings - I'm guessing you had the |
|
Ah, yeah, damn line endings, sorry. Setting core.autocrlf to true has caused its own set of problems, which is why I had it disabled. I'm gonna try setting it to I'll take a stab at writing user documentation, just need to find some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supercedes the InputGroup branch.
A single script can now specify multiple InputLevels. Input generated from a higher InputLevel can trigger hotkeys in a lower level. Example:
The ~LButton hotkey will get triggered for both Numpad0 and LButton presses.