Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all task options to the viewer #325

Open
alexandermendes opened this issue Mar 19, 2018 · 2 comments
Open

Move all task options to the viewer #325

alexandermendes opened this issue Mar 19, 2018 · 2 comments

Comments

@alexandermendes
Copy link
Member

We currently translate a list of task configuration options into an arbitrary task object that is then passed around within the viewer. This somewhat breaks the reactivity of Vue as we can't then easily reconfigure the task, for example, to change a highlighted region or update a form field from outside the module.

One of the advantages to storing task objects initially was to provide the browse functionality but we might need to rethink this...

@alexandermendes
Copy link
Member Author

This was triggered as I start to look at adding the review mode, which will take a list of annotations and present them to the user for review. However, we may need to change these displayed annotations depending on user input and here we realise that reactivity is broken. We either need to regenerate the task or go through an unnecessarily complex process of matching up IDs.

In general, it feels like adding a task configuration forces a particular structure on the user that we don't really need. The browse functionality could still be implemented by the client be responding to clicks of the next/previous buttons.

@alexandermendes
Copy link
Member Author

Another advantage of passing in a list of tasks was so that we could preload the tile sources, however, as we're not actually doing this at the moment it's not functionality that we lose. It could still be something to consider at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant