Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get newer version of auto CA correction and AMaZE #2

Closed
CarVac opened this issue Jun 20, 2016 · 3 comments
Closed

Get newer version of auto CA correction and AMaZE #2

CarVac opened this issue Jun 20, 2016 · 3 comments

Comments

@CarVac
Copy link

CarVac commented Jun 20, 2016

The versions of auto CA correction and AMaZE here are quite old, and in the meantime plenty of work has occurred on them in RawTherapee.

For example, apparently the auto CA correction here has a race condition due to reuse of an array, and so occasionally it gives noticeably incorrect results when the same image loaded in RawTherapee has no issues.

Additionally, both AMaZE and auto CA correction have been optimized and sped up a lot.

Would you be able to update these to newer versions? I'd be able to help out with this if you can guide me on what the inputs and outputs are.

(Also, the LMMSE implementation has been greatly sped up in RawTherapee, with multi-threading, and that might be worth moving it from the GPL2 to the GPL3 demosaic pack)

(Another also, the X-trans implementation has also been improved, and maybe there could be the current slow version in the main repository and a fast version here in the GPL3 demosaic pack)

@LibRaw
Copy link
Owner

LibRaw commented Jun 25, 2016

In LibRaw project we're focused on raw data and metadata decoding, no plans to change/improve postprocessing stage for now.

We're open to user patches/contributions, so if you'll port RawTherapee code to LibRaw's 'demosaic pack' we'll accept these changes in master.

@LibRaw
Copy link
Owner

LibRaw commented Jan 15, 2019

Libraw demosaics packs are not supported since LibRaw 0.19, so the issue is closed.

Hope someone will pick up this code

@LibRaw LibRaw closed this as completed Jan 15, 2019
@CarVac
Copy link
Author

CarVac commented Jan 15, 2019

This is fine. I've started librtprocess in order to share the raw processing algorithms that come after decoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants