Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if rfbProcessClientInitMessage() should lock cl->sendMutex #440

Open
bk138 opened this issue Aug 7, 2020 · 2 comments
Open

check if rfbProcessClientInitMessage() should lock cl->sendMutex #440

bk138 opened this issue Aug 7, 2020 · 2 comments
Labels
enhancement
Milestone
Release 1.0.0

Comments

@bk138
Copy link
Member

bk138 commented Aug 7, 2020

This at least calls rfbTightExtensionInit which calls rfbSendInteractionCaps which has rfbWriteExact.
@bk138 bk138 added this to the Release 1.0.0 milestone Aug 7, 2020
@bk138
Copy link
Member Author

bk138 commented Aug 7, 2020

Same holds true for rfbProcessClientSecurityType which calls

rfbHandleSecTypeTight
   rfbSendTunnelingCaps
       rfbSendAuthCaps
          rfbProcessClientAuthType
             rfbVncAuthSendChallenge

which has rfbWriteExact.

@bk138
Copy link
Member Author

bk138 commented Aug 7, 2020

OTOH, clientOutput thread will not send anything until auth and init are completed. Or? Investigate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 1.0.0
Development

No branches or pull requests
1 participant
@bk138