-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interface for AUX data #626
Comments
We can make sure that |
A quick feedback after using AUX data "for real" for the first time LiberTEM/LiberTEM-blobfinder#23
|
A minor note about dtype behavior: Currently, the dtype defaults to |
Discussion with @sk1p and @Brow71189:
Currently, UDF users have to declare AUX data explicitly when constructing an UDF. This can make using a built-in UDF with aux data unnecessarily complicated.
A cleaner solution could be to implement wrapping parameters in the constructor. That means an UDF implements a specific
__init__
function with dedicated parameters instead of the default catch-all. That is emerging as good practice for documentation purposes anyway. Users pass plain NumPy arrays as specific parameters to the constructor, following the signature and documentation of the UDF. The UDF's constructor then wraps parameters in an AUX buffer as needed and handles them, for example by passing them up to the superclasse's constructor. One just has to take care about parameters being passed again on the worker nodes.The text was updated successfully, but these errors were encountered: